Messages in this thread | | | Date | Fri, 16 Nov 2012 21:22:03 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] uprobes tracer: Add support for @ADDR, @stackN, dereference, bitfield arguments |
| |
Hi Hyeoncheol,
Thank you for working on uprobe enhancement!
First of all, I've failed to apply this on the latest tip tree because of conflict with below patch.
http://marc.info/?l=linux-kernel&m=134869014622386
(2012/11/14 16:13), Hyeoncheol Lee wrote: > Add support for @ADDR, @stackN, dereference, bitfield arguments. Uprobes > tracer supported only register argument. @SYMBOL, $retval, $stack are not > supported. because a symbol address and whether function starts at a given > address can't be known.
I see why the @SYMBOL is not supported, but I can't understand the reason why $retval and $stack aren't supported. At least we can support $stack, isn't it?
> Uprobes tracer and kprobes tracer have their own fetch type information > tables and fetch type functions. But they share printing type functions > and some fetch type functions for register, dereference, and bitfield. > The common functions are defined in trace_probe.c.
By the way, for easy to review and debug, please separate this into several patches. This seems to do (1) moving some interfaces out from trace_probe.c, (2) add fetch_size/fetch members into recursive fetch function data, (3) introduce userspace memory fetching functions, and some cleanups. So, could you split those parts? unless, it is hard to maintain the source code.
Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |