Messages in this thread | | | Date | Fri, 16 Nov 2012 12:30:14 +0100 | From | Wolfram Sang <> | Subject | Re: [RESEND PATCH v3 1/4] i2c: introduce i2c-cbus driver |
| |
On Mon, Nov 12, 2012 at 09:08:42PM +0200, Aaro Koskinen wrote: > Add i2c driver to enable access to devices behind CBUS on Nokia Internet > Tablets. > > The patch also adds CBUS I2C configuration for N8x0 which is one of the > users of this driver. > > Cc: linux-i2c@vger.kernel.org > Acked-by: Felipe Balbi <balbi@ti.com> > Acked-by: Tony Lindgren <tony@atomide.com> > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> > Cc: Wolfram Sang <w.sang@pengutronix.de>
Mostly good, but the devicetree binding description is missing. Please add a proper file with the same name as the driver to Documentation/devicetree/bindings/i2c. Also, it might make sense to rename the driver to i2c-cbus-gpio?
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |