Messages in this thread | | | Date | Thu, 15 Nov 2012 17:18:41 -0800 | From | Greg KH <> | Subject | Re: [PATCH v5 1/2] PCI-Express Non-Transparent Bridge Support |
| |
On Thu, Nov 15, 2012 at 06:06:21PM -0700, Jon Mason wrote: > > > +static inline unsigned int ntb_query_max_cbs(struct ntb_device *ndev) > > > +{ > > > + return ndev->max_cbs; > > > +} > > > > It is shorter, and simpler, to just write the '->variable' version out > > for this, than to make the function call here. Why are these needed? > > Especially when I see the driver code not using them. Please remove. > > This is used in ntb_transport.c. It is used to show how many > interrupts, and there-by clients, the transport layer can have. I can > make it a macro and/or put it in a header file, if that suits you > better.
No, just reference the field of the structure directly, no need for a function or a macro.
thanks,
greg k-h
| |