lkml.org 
[lkml]   [2012]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/4] kernelshark: Full-height cursor and mark lines
    From
    Date
    On Wed, 2012-11-14 at 17:51 -0800, David Sharp wrote:
    > "width" and "height" were swapped, causing the vertical marker and cursor lines
    > to be drawn with the wrong height.

    Is this the fix to the strange "mark bottom stays around" bug? It's been
    on my TODO list for a long time to fix that. ;-)

    -- Steve

    >
    > Signed-off-by: David Sharp <dhsharp@google.com>
    > ---
    > trace-graph.c | 8 ++++----
    > 1 files changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/trace-graph.c b/trace-graph.c
    > index 6f72350..60e5241 100644
    > --- a/trace-graph.c
    > +++ b/trace-graph.c
    > @@ -380,7 +380,7 @@ static void draw_cursor(struct graph_info *ginfo)
    > x = convert_time_to_x(ginfo, ginfo->cursor);
    >
    > gdk_draw_line(ginfo->draw->window, ginfo->draw->style->mid_gc[3],
    > - x, 0, x, ginfo->draw->allocation.width);
    > + x, 0, x, ginfo->draw->allocation.height);
    > }
    >
    > static void draw_marka(struct graph_info *ginfo)
    > @@ -392,7 +392,7 @@ static void draw_marka(struct graph_info *ginfo)
    >
    > x = convert_time_to_x(ginfo, ginfo->marka_time);
    > gdk_draw_line(ginfo->draw->window, green,
    > - x, 0, x, ginfo->draw->allocation.width);
    > + x, 0, x, ginfo->draw->allocation.height);
    > }
    >
    > static void draw_markb(struct graph_info *ginfo)
    > @@ -404,7 +404,7 @@ static void draw_markb(struct graph_info *ginfo)
    >
    > x = convert_time_to_x(ginfo, ginfo->markb_time);
    > gdk_draw_line(ginfo->draw->window, red,
    > - x, 0, x, ginfo->draw->allocation.width);
    > + x, 0, x, ginfo->draw->allocation.height);
    > }
    >
    > static void update_with_backend(struct graph_info *ginfo,
    > @@ -434,7 +434,7 @@ static void
    > draw_line(GtkWidget *widget, gdouble x, struct graph_info *ginfo)
    > {
    > gdk_draw_line(widget->window, widget->style->black_gc,
    > - x, 0, x, widget->allocation.width);
    > + x, 0, x, widget->allocation.height);
    > }
    >
    > static void clear_line(struct graph_info *ginfo, gint x)




    \
     
     \ /
      Last update: 2012-11-15 04:01    [W:4.090 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site