Messages in this thread | | | Date | Wed, 14 Nov 2012 15:41:53 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH v5 11/11] thp, vmstat: implement HZP_ALLOC and HZP_ALLOC_FAILED events |
| |
On Wed, 7 Nov 2012, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > hzp_alloc is incremented every time a huge zero page is successfully > allocated. It includes allocations which where dropped due > race with other allocation. Note, it doesn't count every map > of the huge zero page, only its allocation. > > hzp_alloc_failed is incremented if kernel fails to allocate huge zero > page and falls back to using small pages. >
Nobody is going to know what hzp_ is, sorry. It's better to be more verbose and name them what they actually are: THP_ZERO_PAGE_ALLOC and THP_ZERO_PAGE_ALLOC_FAILED. But this would assume we want to lazily allocate them, which I disagree with hpa about.
| |