Messages in this thread | | | Date | Wed, 14 Nov 2012 12:04:14 +0900 | From | Mark Brown <> | Subject | Re: [PATCH V3 1/2] mfd: add TI TPS80031 mfd core driver |
| |
On Tue, Nov 13, 2012 at 10:01:26PM -0500, Laxman Dewangan wrote:
> >This does not seem sensible. Why would this be optional if it is > >useful? In any case, what you're doing in the driver here is clearly > >not the way forward.
> I was thinking of adding wake_enable in struct regmap_irq_chip and > decide the wake support based on the value if wake_enable true or > wake_base is non-zero. then wake support should be enable. > The wake register write will happen only when wake_base is non-zero.
But to repeat my question why would this be optional? [unhandled content-type:application/pgp-signature] | |