lkml.org 
[lkml]   [2012]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/46] x86, mm: setup page table in top-down
On 11/13/2012 11:59 AM, Yinghai Lu wrote:
>>
>> The changes to init_mem_mapping are a bit iffy but they aren't too
>> unreasonable.
>> Overall the patch is OK even though I would certainly appreciate more
>> comments and better variable names (real_end?), see below.
>
> real_end is not good?
>
> xen put big reserved range between real_end and end.
>
> that real_end is some kind of end of real usable areas.
>
> so change to real_usable_end or usable_end?
>

A description of a variable that includes the words "some kind of"
clearly indicates major confusion. We need to know what the semantics
are, here.

-hpa



\
 
 \ /
  Last update: 2012-11-13 21:21    [W:0.083 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site