lkml.org 
[lkml]   [2012]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/46] x86, mm: Split out split_mem_range from init_memory_mapping
From
On Mon, Nov 12, 2012 at 11:03 PM,  <snakky.zhang@gmail.com> wrote:
> On 2012年11月13日 14:20, Yinghai Lu wrote:
>>> 2012/11/13 6:17, Yinghai Lu wrote:
>>>>
>>>> + nr_range = 0;
>>>
>>> This is unnecessary since it is set in the below.
>>>
>>>> + nr_range = split_mem_range(mr, nr_range, start, end);
>>
>> ^^^^^^^^
>
> Why not use 0 directly?
>
> nr_range = split_mem_range(mr, 0, start, end);

yes, even could remove nr_range from split_mem_range.

but originally try to like "really" chopping the code to two parts.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-11-13 20:21    [W:1.507 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site