Messages in this thread | | | From | David Howells <> | Subject | Re: [GIT PULL] UAPI: perf fixes | Date | Tue, 13 Nov 2012 15:24:31 +0000 |
| |
Josh Boyer <jwboyer@gmail.com> wrote:
> This patch seems to break building perf on ppc64. It fails with: > > + make -j16 -C tools/perf -s V=1 WERROR=0 HAVE_CPLUS_DEMANGLE=1 prefix=/usr all > > <snip> > > builtin-kvm.c:25:21: fatal error: asm/svm.h: No such file or directory
tools/perf/builtin-kvm.c became x86-only with the following commit:
commit bcf6edcd6fdb8965290f0b635a530fa3c6c212e1 Author: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> Date: Mon Sep 17 16:31:15 2012 +0800 Subject: perf kvm: Events analysis tool
when it added:
+#include "../../arch/x86/include/asm/svm.h" +#include "../../arch/x86/include/asm/vmx.h" +#include "../../arch/x86/include/asm/kvm.h"
and my changing these to <asm/foo.h> doesn't matter because of this in the same file:
+struct exit_reasons_table vmx_exit_reasons[] = { + VMX_EXIT_REASONS +}; + +struct exit_reasons_table svm_exit_reasons[] = { + SVM_EXIT_REASONS +};
which use macros only x86 defines.
Should the exported parts of these files be moved to asm-generic?
David
| |