Messages in this thread | | | Date | Mon, 12 Nov 2012 23:31:13 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH v3 2/9] net: rds: use this_cpu_ptr per-cpu helper |
| |
On Mon, 12 Nov 2012, Shan Wei wrote:
> __percpu annotations in struct rds_ib_refill_cache is missing. > > you mean that read/write fields of struct rds_ib_cache_head > using __this_cpu_* operation like following? > How about it? > > diff --git a/net/rds/ib.h b/net/rds/ib.h > index 8d2b3d5..7280ab8 100644 > --- a/net/rds/ib.h > +++ b/net/rds/ib.h > @@ -50,7 +50,7 @@ struct rds_ib_cache_head { > }; > > struct rds_ib_refill_cache { > - struct rds_ib_cache_head *percpu; > + struct rds_ib_cache_head __percpu *percpu;
That looks ok.
| |