Messages in this thread | | | Subject | Re: [PATCH 001/104] checkpatch: warn about using CONFIG_EXPERIMENTAL | From | Joe Perches <> | Date | Mon, 12 Nov 2012 14:49:11 -0800 |
| |
On Mon, 2012-11-12 at 14:43 -0800, Kees Cook wrote: > On Mon, Nov 5, 2012 at 8:18 PM, Joe Perches <joe@perches.com> wrote: > > On Mon, 2012-11-05 at 15:03 -0800, Kees Cook wrote: > >> This config item has not carried much meaning for a while now and is > >> almost always enabled by default. As agreed during the Linux kernel > >> summit, it is being removed. This will discourage future addition of > >> CONFIG_EXPERIMENTAL while it is being phased out. > >> > >> Cc: Andy Whitcroft <apw@canonical.com> > >> Signed-off-by: Kees Cook <keescook@chromium.org> > >> --- > >> scripts/checkpatch.pl | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > >> index 21a9f5d..f8b33ed 100755 > >> --- a/scripts/checkpatch.pl > >> +++ b/scripts/checkpatch.pl > >> @@ -1757,6 +1757,13 @@ sub process { > >> #print "is_start<$is_start> is_end<$is_end> length<$length>\n"; > >> } > >> > >> +# Discourage the addition of CONFIG_EXPERIMENTAL in Kconfig. > >> + if ($realfile =~ /Kconfig/ && > >> + $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) { > >> + WARN("CONFIG_EXPERIMENTAL", > >> + "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see:\nhttps://lkml.org/lkml/2012/10/23/580\n"); > >> + } > >> + > >> if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && > >> ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { > >> my $flag = $1; > > > > Couple bits of trivia: > > > > Perhaps this would be better if it didn't just check Kconfig > > files and simply looked for any use of CONFIG_EXPERIMENTAL > > > > $line =~ /^\+.*\bCONFIG_EXPERIMENTAL\b/ > > > > I think the output WARN would be better on single line. > > > > "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives see https://lkml.org/lkml/2012/10/23/580\n" > > Good idea! I've added a check for this now too. I made it look for > /^\+\s*\#if\s*.*\bCONFIG_EXPERIMENTAL\b/ just to limit it a bit more.
There are many config uses like: #if defined(CONFIG_FOO) and #if defined CONFIG_FOO || defined CONFIG_BAR
so I think any line that has this specific config option is suspect.
| |