lkml.org 
[lkml]   [2012]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] [PATCH] tpm: add documentation for sysfs interfaces
Hi Peter,

On Mon, Nov 12, 2012 at 08:47:55AM +0000, Peter.Huewe@infineon.com wrote:
> Hi Kent,
>
> thanks a lot for this effort!
> I really appreciate it.
>
> > +What: /sys/class/misc/tpmX/device/active
> > +Date: April 2006
> > +KernelVersion: 2.6.17
> > +Contact: tpmdd-devel@lists.sf.net
> > +Description: The "active" property prints a '1' if the TPM chip is accepting
> > + commands. An inactive TPM chip still contains all the state of
> > + an active chip (Storage Root Key, NVRAM, etc), and can be
> > + visible to the OS, but will not accept commands.
>
> Hmm, I know this is a tricky one (enabled/activated).
> maybe this would be better as:
> - visible to the OS, but will not accept commands.
> + visible to the OS, but will only accept a restricted set of commands.
> + See TCG specification(...) for more information.

Yeah that's more accurate. I'm just inclined to point to the design
principles and structures spec here unless you have a better idea. Both
have enabled/activated info scattered throughout them. Sigh. :)

>
>
> > +What: /sys/class/misc/tpmX/device/cancel
> > +Date: June 2005
> > +KernelVersion: 2.6.13
> > +Contact: tpmdd-devel@lists.sf.net
> > +Description: The "cancel" property allows you to cancel the currently
> > + pending TPM command. Echoing any value to cancel will call the
> > + TPM vendor specific cancel operation.
>
> I'd go for writing instead of echoing but this might only be bike-shedding.
> - pending TPM command. Echoing any value to cancel will call the
> + pending TPM command. Writing any value to cancel will call the

Sounds good.

Thanks,
Kent

>
> The rest is great.
> Reviewed-by: Peter Huewe <peter.huewe@infineon.com>
> Signed-off-by: Peter Huewe <peter.huewe@infineon.com>
>
>
> Thanks,
> Peter
>



\
 
 \ /
  Last update: 2012-11-12 17:01    [W:0.044 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site