Messages in this thread | | | Date | Mon, 12 Nov 2012 10:03:00 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH] alpha: use BUG_ON where possible |
| |
On 11/12/2012 09:43 AM, Jiri Kosina wrote: > On Fri, 9 Nov 2012, Sasha Levin wrote: > >>>> Just use BUG_ON() instead of constructions such as: >>>> >>>> if (...) >>>> BUG() >>>> >>>> A simplified version of the semantic patch that makes this transformation >>>> is as follows: (http://coccinelle.lip6.fr/) >>>> >>>> // <smpl> >>>> @@ >>>> expression e; >>>> @@ >>>> - if (e) BUG(); >>>> + BUG_ON(e); >>> >>> Ok, I guess I am just going to apply this one. Thanks, >>> >> >> So I have about 80 more of these. I've sent out the first 10 to make sure >> that they look fine and the only complaints I got about them are that they are >> trivial :) >> >> Can I send the rest directly to you to go through the trivial tree? > > How many conflict can you see if you generate this patch on top of Linus' > tree and thn apply it to linux-next? >
One context conflict.
Thanks, Sasha
| |