Messages in this thread | | | Date | Mon, 12 Nov 2012 13:35:21 +0100 | From | Jiri Slaby <> | Subject | Re: [PATCH] HID: microsoft, do not use compound literal |
| |
On 11/12/2012 01:30 PM, Geert Uytterhoeven wrote: > My comment was purely cosmetic, as it applies to the quoted compiler error > messages only.
Ah, I see. When you are applying the patch Jiri, could you remove errors about line 50 from the commit log? What I wanted to have there apparently was only "hid-microsoft.c:51:18: error: macro "memcmp" passed 6 arguments, but takes just 3".
> Your latest version doesn't use memcmp() anymore, so I think there's no need to > include <linux/string.h> anymore.
s/Your/His/ perhaps :). Otherwise I'd be confused -- did Jiri send some other version?
thanks, -- js suse labs
| |