lkml.org 
[lkml]   [2012]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Bisected regression: iterate_fd() selinux change affects flash plugin
Quoting Pavel Roskin <proski@gnu.org>:

> Hello, Al!
>
> I have noticed that Mozilla Firefox gets stuck for seconds or minutes
> on some sites, in particular on Facebook with Linux 3.7-rc1 and newer
> mainline kernels. Disabling flash plugin fixes the delays.
>
> This is a Fedora 17 system with SELinux enabled, on x86_64
> architecture, with all updates, with LXDE desktop. It's not the Fedora
> 16 system I mentioned before, it has never had LXDE login problems due
> to replace_fd().
>
> Bisecting lead me to the patch that introduced iterate_fd():
>
> commit c3c073f808b22dfae15ef8412b6f7b998644139a
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date: Tue Aug 21 22:32:06 2012 -0400
>
> new helper: iterate_fd()
>
> iterates through the opened files in given descriptor table,
> calling a supplied function; we stop once non-zero is returned.
> Callback gets struct file *, descriptor number and const void *
> argument passed to iterator. It is called with files->file_lock
> held, so it is not allowed to block.
>
> tty_io, netprio_cgroup and selinux flush_unauthorized_files()
> converted to its use.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> I have found that reverting the changes to security/selinux/hooks.c is
> sufficient to restore the correct behavior.
>
> --
> Regards,
> Pavel Roskin

I've made a bugzilla entry for the bug and put a preliminary patch there.
https://bugzilla.kernel.org/show_bug.cgi?id=50401

--
Regards,
Pavel Roskin


\
 
 \ /
  Last update: 2012-11-12 06:41    [W:0.051 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site