Messages in this thread Patch in this message | | | Date | Mon, 12 Nov 2012 10:13:55 +0530 | From | Tushar Behera <> | Subject | Re: [PATCH] regulator: core: Update regulator_is_supported_voltage for fixed voltages |
| |
On 11/09/2012 10:39 PM, Mark Brown wrote: > On Fri, Nov 09, 2012 at 04:21:49PM +0530, Tushar Behera wrote: > >> In case of fixed regulators for which voltage cannot be changed, >> regulator_is_supported_voltage should return success only if the >> min_uV and max_uV parameters are same and it is equal to the current >> voltage of the regulator. > > This makes no sense to me at all. The caller is asking if it's possible > to set the voltage between the minimum and maximum values, any voltage > in that range should be OK. Your patch makes the function massively > less useful. >
Ok.
In that case, we should modify the test condition as following. Currently it passes success when the regulator voltage is less than both min_uV and max_uV. If ok, I will send another patch for this.
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 1a35251..e90e5c3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1974,7 +1974,7 @@ int regulator_is_supported_voltage(struct regulator *regulator, if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) { ret = regulator_get_voltage(regulator); if (ret >= 0) - return (min_uV >= ret && ret <= max_uV); + return (ret >= min_uV && ret <= max_uV); else return ret; }
-- Tushar Behera
| |