Messages in this thread | | | Date | Mon, 12 Nov 2012 09:45:56 +0800 | From | Shan Wei <> | Subject | Re: [PATCH v3 3/9] net: xfrm: use __this_cpu_read per-cpu helper |
| |
Christoph Lameter said, at 2012/11/10 4:12: > On Fri, 9 Nov 2012, Shan Wei wrote: > >> v3 fix compile warning: >> net/xfrm/xfrm_ipcomp.c: In function 'ipcomp_alloc_tfms': >> net/xfrm/xfrm_ipcomp.c:285: warning: assignment from incompatible pointer type > > Why exactly is the pointer type not compatible? Looks like we have a > problem here. >
pos->tfms(struct crypto_comp **tfms) is a double pointer that point to struct crypto_comp. returned value is a pointer that point to struct crypto_comp; So, we need to dereference and then read.
+ tfm = __this_cpu_read(*pos->tfms);
I will update this patch in v4 to fix it.
Thanks~
| |