lkml.org 
[lkml]   [2012]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] vmxnet3: convert BUG_ON(true) into a simple BUG()
    On 09/11/12 07:23, Sasha Levin wrote:
    > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
    > ---
    > drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
    > index 0ae1bcc..7e9622f 100644
    > --- a/drivers/net/vmxnet3/vmxnet3_drv.c
    > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
    > @@ -1922,7 +1922,7 @@ vmxnet3_free_irqs(struct vmxnet3_adapter *adapter)
    > free_irq(adapter->pdev->irq, adapter->netdev);
    > break;
    > default:
    > - BUG_ON(true);
    > + BUG();
    > }
    > }

    All of the BUG_ON tests in this function look like programming error
    assertions. It looks like the worst that would happen is that some irqs
    might not be properly released, not the sort of thing that is going to
    make the system unstable if you don't bug.

    Can't they just be replaced with (for example):

    if (WARN_ON(blah))
    return;

    Or even just:

    netdev_err(adapter->netdev, "bad irq type %d for free\n",
    intr->type);

    ~Ryan



    \
     
     \ /
      Last update: 2012-11-11 23:41    [W:4.008 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site