lkml.org 
[lkml]   [2012]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ARM: zynq: Allow UART1 to be used as DEBUG_LL console.
On 2012-10-30 12:27 +0100, Michal Simek wrote:
> On 10/29/2012 07:19 PM, Nick Bowler wrote:
> > +#if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1)
> > +# define LL_UART_PADDR UART1_PHYS
> > +# define LL_UART_VADDR UART_VIRT
> > +#else
> > +# define LL_UART_PADDR UART0_PHYS
> > +# define LL_UART_VADDR UART_VIRT
> > +#endif
>
> Probably no reason to setup LL_UART_VADDR on two lines.
> It is enough to set it up once.
>
> MINOR: It is just my personal preference to use different coding style.
>
> #if IS_ENABLED(CONFIG_DEBUG_ZYNQ_UART1)
> # define LL_UART_PADDR UART1_PHYS
> #else
> # define LL_UART_PADDR UART0_PHYS
> #endif
>
> #define LL_UART_VADDR UART_VIRT

I have no strong feeling either way, so I will send v3 with these
changes.

Thanks,
--
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)


\
 
 \ /
  Last update: 2012-11-01 20:21    [W:0.055 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site