Messages in this thread | | | Date | Thu, 1 Nov 2012 14:34:51 -0400 | From | Murali Karicheri <> | Subject | Re: [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver |
| |
On 11/01/2012 08:41 AM, Sekhar Nori wrote: > On 10/25/2012 9:41 PM, Murali Karicheri wrote: >> This is the common clk driver initialization functions for DaVinci >> SoCs and other SoCs that uses similar hardware architecture. >> clock.h also defines struct types for clock definitions in a SoC >> and clock data type for configuring clk-mux. The initialization >> functions are used by clock initialization code in a specific >> platform/SoC. >> >> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com> >> +struct clk *davinci_plldiv_clk(const char *name, const char *parent, >> + struct clk_plldiv_data *data) >> +{ >> + /* >> + * This is a PLL divider clock with divider specified by >> + * div_reg in pll_div_data. >> + */ >> + data->reg = ioremap(data->phys_div_reg, 4); >> + if (WARN_ON(!data->reg)) >> + return NULL; >> + >> + return clk_register_davinci_plldiv(NULL, name, parent, data, &_lock); > This function does not exist at this point. Looks like you need to swap > 3/11 with 4/11. Also, you should also add build infrastructure > (makefile, Kconfig) changes in the same patch that creates the file. > There is no point in adding those separately. > > Thanks, > Sekhar > Sekhar,
So the Makefile, Kconfig and new files should be in the same patch. Also will re-order the 3/11 and 4/11 in the next revision.
Murali
| |