lkml.org 
[lkml]   [2012]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: Don't attempt to allocate zero bytes with vmalloc()
On Tue, Oct 09, 2012 at 06:56:02AM +0800, Ming Lei wrote:

> Considered that zero-length firmware image doesn't make sense for drivers
> (callers), maybe it is a insane firmware image, so how about treating it as a
> failure?

It seems better to punt that decision to callers - for example, the case
I ran into this with was a driver that was using a zero length firmware
to say that it didn't want to load an optional image but also didn't
want to have to time out if that was the case. That doesn't seem
unreasonable to me, and drivers already have to validate that what
they're getting makes sense.


\
 
 \ /
  Last update: 2012-10-09 07:01    [W:0.046 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site