Messages in this thread | | | Date | Mon, 8 Oct 2012 23:21:15 -0700 | Subject | Re: [PATCH -v2 00/10] x86: Use BRK to pre mapping page table to make xen happy | From | Yinghai Lu <> |
| |
On Mon, Oct 8, 2012 at 11:07 PM, H. Peter Anvin <hpa@zytor.com> wrote: > On 10/09/2012 12:39 PM, Yinghai Lu wrote: >> on top of tip/x86/mm2 > > Hi Yinghai, > > This patchset doesn't apply on top of tip:x86/mm2, starting at patch 08/10.
sorry for that. I refresh my base to current linus/master and tip/master.
could be some change there.
could solve it: 1. update x86/mm2 to linus/master 2. or i resend the patch again with x86/mm2 as base.
please let me know which one you like.
> > Furthermore, a lot of the descriptions are both incomplete and > incomprehensible, which makes the patchset very very hard to review. > > You should think of the descriptions as writing a (short) paper on your > patchset, where you describe not just what you are doing, but how you > accomplish the objective and why that objective is the right thing do > accomplish.
Actually I spent a while on the changelog of this patchset.
will spend more time for next reversion.
> > Overall, this patchset seems to be going in the right direction, but I > have several concerns with details.
good, will update the patches accordingly.
Thanks
Yinghai
| |