Messages in this thread | | | From | (Eric W. Biederman) | Date | Tue, 09 Oct 2012 13:20:48 -0700 | Subject | Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports |
| |
"Myklebust, Trond" <Trond.Myklebust@netapp.com> writes:
> On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: >> Cc'ing Eric since I seem to recall he suggested doing it this way?
Yes. On second look setting fs->root won't work. We need to change fs. The problem is that by default all kernel threads share fs so changing fs->root will have non-local consequences.
I very much believe we want if at all possible to perform a local modification.
Changing fs isn't all that different from what devtmpfs is doing.
>> Seems OK to me, but maybe that swap_root should be in common code? (Or >> maybe we could use set_fs_root()?) >> >> I'm assuming it's up to Trond to take this.--b. > > I'm reluctant to do that at this time since the original proposal was > precisely that of export set_fs_root() and using it around the AF_LOCAL > socket bind. That proposal was NACKed by Al Viro.
> If Al is OK with the idea of us creating a private version of > set_fs_root, then I'd like to see an official Acked-by: that we can > append to this commit.
Eric
| |