Messages in this thread | | | From | Paul Turner <> | Date | Tue, 9 Oct 2012 11:35:25 -0700 | Subject | Re: sched: per-entity load-tracking |
| |
On Sat, Oct 6, 2012 at 12:39 AM, Ingo Molnar <mingo@kernel.org> wrote: > > * Paul Turner <pjt@google.com> wrote: > >> Peter: >> The rebase to tip/master made interdiff angry enough that it wasn't >> producing the right relative diffs for your stack. Sorry :( > > Find below the diff between the two series, using 'quilt > snapshot' and 'quilt diff --snapshot'.
So what I was looking to generate here were per-patch differences that Peter could squash into his quilt stack directly. I typically find interdiff works quite well for this, with the exception of the changelog.
> > One quick stylistic note: instead of putting the > update_cfs_rq_blocked_load() in the middle of the file, order > functions naturally so that no prototypes are needed.
This is certainly a principle I agree with, and I'm not gun-shy about moving things around to reduce this burden :)
However, in this case I think the prototype is preferable as this code is right in the middle of the 'core' helper functions for fair.c which naturally live at the top of the file. Promoting the group scheduling bits to remove this dependency would place them several hundred lines down and be counter-productive towards this structure.
However, if you still feel strongly, it can certainly be done.
Thanks!
- Paul
| |