Messages in this thread Patch in this message | | | Date | Tue, 9 Oct 2012 10:19:21 -0700 | From | tip-bot for Namhyung Kim <> | Subject | [tip:perf/core] perf trace: Validate target task/user/cpu argument |
| |
Commit-ID: 32caf0d1fe14eb69191e7828701e381b1edb340d Gitweb: http://git.kernel.org/tip/32caf0d1fe14eb69191e7828701e381b1edb340d Author: Namhyung Kim <namhyung.kim@lge.com> AuthorDate: Fri, 5 Oct 2012 14:02:13 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 5 Oct 2012 12:47:54 -0300
perf trace: Validate target task/user/cpu argument
Those target options are mutually exclusive so check it before setting up target thread/cpu maps.
Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1349413336-26936-2-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-trace.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index dec8ced..f01fa6f 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c @@ -323,14 +323,21 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) OPT_END() }; int err; + char bf[BUFSIZ]; argc = parse_options(argc, argv, trace_options, trace_usage, 0); if (argc) usage_with_options(trace_usage, trace_options); + err = perf_target__validate(&trace.opts.target); + if (err) { + perf_target__strerror(&trace.opts.target, err, bf, sizeof(bf)); + printf("%s", bf); + return err; + } + err = perf_target__parse_uid(&trace.opts.target); if (err) { - char bf[BUFSIZ]; perf_target__strerror(&trace.opts.target, err, bf, sizeof(bf)); printf("%s", bf); return err;
| |