Messages in this thread | | | Subject | Re: [PATCH 1/2] random: make it possible to enable debugging without rebuild | From | Joe Perches <> | Date | Mon, 08 Oct 2012 12:45:50 -0700 |
| |
On Mon, 2012-10-08 at 16:39 +0200, Jiri Kosina wrote: > The module parameter that turns debugging mode (which basically means > printing a few extra lines during runtime) is in '#if 0' block. Forcing > everyone who would like to see how entropy is behaving on his system seems > to be a little bit too harsh. > If we were concerned about speed, we could potentially turn 'debug' into > a static key, but I don't think it's necessary. > > Drop the '#if 0' block to allow using the 'debug' parameter without rebuilding.
I'd also convert the printk(KERN_DEBUG to pr_debug to avoid penalizing non-debug builds altogether.
| |