lkml.org 
[lkml]   [2012]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 089/108] sierra_net: Endianess bug fix.
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>

    [ Upstream commit 2120c52da6fe741454a60644018ad2a6abd957ac ]

    I discovered I couldn't get sierra_net to work on a powerpc. Turns out
    the firmware attribute check assumes the system is little endian and
    hence fails because the attributes is a 16 bit value.

    Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/usb/sierra_net.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c
    index 864448b..e773250 100644
    --- a/drivers/net/usb/sierra_net.c
    +++ b/drivers/net/usb/sierra_net.c
    @@ -678,7 +678,7 @@ static int sierra_net_get_fw_attr(struct usbnet *dev, u16 *datap)
    return -EIO;
    }

    - *datap = *attrdata;
    + *datap = le16_to_cpu(*attrdata);

    kfree(attrdata);
    return result;



    \
     
     \ /
      Last update: 2012-10-08 04:01    [W:4.130 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site