Messages in this thread | | | Date | Fri, 05 Oct 2012 10:09:04 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH] net, TTY: initialize tty->driver_data before usage |
| |
On 10/05/2012 02:01 AM, Sasha Levin wrote: > Commit 9c650ffc ("TTY: ircomm_tty, add tty install") split _open() to > _install() and _open(). It also moved the initialization of driver_data > out of open(), but never added it to install() - causing a NULL ptr > deref whenever the driver was used. > > Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > --- > net/irda/ircomm/ircomm_tty.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c > index 95a3a7a..496ce2c 100644 > --- a/net/irda/ircomm/ircomm_tty.c > +++ b/net/irda/ircomm/ircomm_tty.c > @@ -421,6 +421,8 @@ static int ircomm_tty_install(struct tty_driver *driver, struct tty_struct *tty) > hashbin_insert(ircomm_tty, (irda_queue_t *) self, line, NULL); > } > > + tty->driver_data = self; > + > return tty_port_install(&self->port, driver, tty);
Yes, a good catch.
Acked-by: Jiri Slaby <jslaby@suse.cz>
thanks, -- js suse labs
| |