Messages in this thread | | | Date | Fri, 05 Oct 2012 16:13:34 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH 1/2] perf, cpu hotplug: Run CPU_STARTING notifiers with irqs disabled |
| |
On 09/13/2012 08:12 PM, Srivatsa S. Bhat wrote: > The CPU_STARTING notifiers are supposed to be run with irqs disabled. But the > perf_cpu_notifier() macro invokes them without doing that. Fix it. > > Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > ---
Any thoughts on this?
Regards, Srivatsa S. Bhat
> > include/linux/perf_event.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 7602ccb..cc4574d 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -1346,10 +1346,13 @@ static inline void perf_event_task_tick(void) { } > do { \ > static struct notifier_block fn##_nb __cpuinitdata = \ > { .notifier_call = fn, .priority = CPU_PRI_PERF }; \ > + unsigned long flags; \ > fn(&fn##_nb, (unsigned long)CPU_UP_PREPARE, \ > (void *)(unsigned long)smp_processor_id()); \ > + local_irq_save(flags); \ > fn(&fn##_nb, (unsigned long)CPU_STARTING, \ > (void *)(unsigned long)smp_processor_id()); \ > + local_irq_restore(flags); \ > fn(&fn##_nb, (unsigned long)CPU_ONLINE, \ > (void *)(unsigned long)smp_processor_id()); \ > register_cpu_notifier(&fn##_nb); \ >
| |