lkml.org 
[lkml]   [2012]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 18/52] TTY: ttyprintk, dont touch behind tty->write_buf
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiri Slaby <jslaby@suse.cz>

    commit ee8b593affdf893012e57f4c54a21984d1b0d92e upstream.

    If a user provides a buffer larger than a tty->write_buf chunk and
    passes '\r' at the end of the buffer, we touch an out-of-bound memory.

    Add a check there to prevent this.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Samo Pogacnik <samo_pogacnik@t-2.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/ttyprintk.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/ttyprintk.c
    +++ b/drivers/char/ttyprintk.c
    @@ -67,7 +67,7 @@ static int tpk_printk(const unsigned cha
    tmp[tpk_curr + 1] = '\0';
    printk(KERN_INFO "%s%s", tpk_tag, tmp);
    tpk_curr = 0;
    - if (buf[i + 1] == '\n')
    + if ((i + 1) < count && buf[i + 1] == '\n')
    i++;
    break;
    case '\n':



    \
     
     \ /
      Last update: 2012-10-05 00:21    [W:5.406 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site