Messages in this thread | | | Date | Thu, 4 Oct 2012 08:13:50 -0700 | Subject | Re: [PATCH 4/5] PCI: Add max_vfs in sysfs per pci device where supports | From | Yinghai Lu <> |
| |
On Thu, Oct 4, 2012 at 7:15 AM, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote: > On Wed, Oct 03, 2012 at 10:51:34AM -0700, Yinghai Lu wrote: >> only pci device that support sriov will have max_vfs show up in /sys > ^-Only ^-devices ^-SRIOV > >> >> when user set value in /sys, driver ops set_max_vfs will be called to enable >> VF there. > > Huh? What value? What are they enabling? Your comment makes it sound as > if setting any value (say '0xdeadbeef') will be called to enable a VF. > > I don't think that is what the code does. Can you explain what the > proper values are to be submitted to the SysFS value 'max_vfs' and > what the kernel ought to be doing? Perhaps include a little snippet > from the kernel log so if somebody has a bug they can look at see > what you got and can compare?
I sent out this patches as reference or base for Don and greg.rose and other sriov guys.
Anyway, thank you for review them.
Yinghai
| |