Messages in this thread | | | Date | Wed, 31 Oct 2012 10:25:22 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/8] cgroup: kill CSS_REMOVED |
| |
Hello,
On Wed, Oct 31, 2012 at 09:19:51PM +0400, Glauber Costa wrote: > I don't see post_create failing as a huge problem. The natural > synchronization point would be "right after post_create" - then you can > definitely tell that it is online. Although this can be viewed a bit as > "exposing internals", creating is different then destroying: When you > create, you may not have all data yet. When destroying, you do - and > want to get rid of it. So this kind of bootstrapping is pretty standard > and common.
More proper names for these callbacks would be,
->allocate() ->online() ->offline() ->free()
And I may rename them. I don't wanna make ->online() failable. Why can't you just allocate everything from ->allocate() and use it from ->online()?
Thanks.
-- tejun
| |