Messages in this thread | | | Date | Wed, 31 Oct 2012 20:18:31 +0530 | From | Laxman Dewangan <> | Subject | Re: [PATCH 2/2] dma: tegra20-apbdma: channel freeing correction |
| |
On Sunday 28 October 2012 07:47 PM, Dmitry Osipenko wrote: > Fixed channel "lock" after free. > > Example: Channel 1 was allocated and prepared as slave_sg, used and freed. Now preparation of cyclic dma on channel 1 will fail with err "DMA > configuration conflict" because tdc->isr_handler still selected to handle_once_dma_done. > > This happens because tegra_dma_abort_all() won't be called on channel freeing if pending list is empty. > > Signed-off-by: Dmitry Osipenko<digetx@gmail.com>
Both patches looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
| |