| Date | Wed, 31 Oct 2012 10:18:49 -0700 | From | Tejun Heo <> | Subject | Re: [PATCHSET] cgroup: simplify cgroup removal path |
| |
Hello,
On Wed, Oct 31, 2012 at 05:49:33PM +0400, Glauber Costa wrote: > The only think that drew my attention is that you are changing the > local_irq_save callsite to local_irq_disable. It shouldn't be a problem, > since this is never expected to be called in interrupt context. > > Still... it makes me wonder if that disabled-interrupt block is still > needed? According to the changelogs, it was introduced in e7c5ec919 for > the css_tryget mechanism. But css_tryget itself will never scan > subsystems, so if we can no longer fail, we should be able to just ditch > it. Unless I am missing something
Note both in the commit messages.
Thanks.
-- tejun
|