Messages in this thread | | | Date | Tue, 30 Oct 2012 08:53:38 -0700 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/9] perf python: add ui stubs file |
| |
Em Tue, Oct 30, 2012 at 08:45:28AM -0600, David Ahern escreveu: > On 10/30/12 1:24 AM, Namhyung Kim wrote: > >On Mon, 29 Oct 2012 10:31:41 -0600, David Ahern wrote: > >>stdio based implementations of ui_xxxx based functions for the python > >>library. Needed for patch 3 - consolidating open counters method.
> >How about adding ui/util.c to the python-ext-sources?
> Handles some of the ui_xxxx functions, but still missing some > symbols -- verbose, eprintf, ui__error_paranoid. The point of the > python_stubs.c was a short term solution for the ui handlers. > Arnaldo had some ideas on what is really needed.
Yes, and that is something like what Namhyung did for perf_target, i.e. don't call ui__ stuff from the evsel/evlist classes but use a perf_evlist__strerror, merge perf_evlist__open_counters() with perf_evlist__open(), use just perf_evlist__open() everywhere, so that all tools get the fallbacks for features not present in older kernels, etc.
- Arnaldo
| |