Messages in this thread | | | Date | Tue, 30 Oct 2012 14:57:57 -0700 | Subject | Re: [PATCH 1/4] module: add syscall to load module from fd | From | Kees Cook <> |
| |
On Mon, Oct 22, 2012 at 12:39 AM, Rusty Russell <rusty@rustcorp.com.au> wrote: > "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com> writes: >>> FIX: add flags arg to sys_finit_module() >>> >>> Thanks to Michael Kerrisk for keeping us honest. >> >> w00t! Thanks, Rusty ;-). >> >> Acked-by: Michael Kerrisk <mtk.manpages@gmail.com> > > Here's the version I ended up with when I added two flags. > > Lucas, is this useful to you? > > BTW Michael: why aren't the syscall man pages in the kernel source? > > Thanks, > Rusty. > > module: add flags arg to sys_finit_module() > > Thanks to Michael Kerrisk for keeping us honest. These flags are actually > useful for eliminating the only case where kmod has to mangle a module's > internals: for overriding module versioning. > > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Rusty,
I haven't seen this land in your modules-next tree. I just wanted to make sure it hadn't gotten lost. I'd like to do some kmod tests against linux-next, but I've been waiting for this to appear.
I acked this before, but as long as I'm replying again:
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook Chrome OS Security
| |