Messages in this thread | | | Date | Tue, 30 Oct 2012 14:42:57 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable |
| |
Hello,
Just some nitpicks.
On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote: > +/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit kernels. */ > +#define hash_min(val, bits) \ > +({ \ > + sizeof(val) <= 4 ? \ > + hash_32(val, bits) : \ > + hash_long(val, bits); \ > +})
Doesn't the above fit in 80 column. Why is it broken into multiple lines? Also, you probably want () around at least @val. In general, it's a good idea to add () around any macro argument to avoid nasty surprises.
Looks good to me otherwise.
Reviewed-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |