Messages in this thread | | | Date | Tue, 30 Oct 2012 15:35:24 -0400 | From | Behan Webster <> | Subject | Re: [PATCH 1/2] Helper macros used for replacing the use of VLAIS |
| |
On 12-10-30 03:20 PM, Greg KH wrote: > On Tue, Oct 30, 2012 at 02:25:19PM -0400, Behan Webster wrote: >> The use of variable length arrays in structs (VLAIS) in the Linux Kernel code >> precludes the use of compilers which don't implement VLAIS (for instance the >> Clang compiler). This new header file contains macros which can be used to >> calculate the size and offset of variables in an allocated buffer of memory >> taking into account alignment issues. >> >> Signed-off-by: Behan Webster <behanw@converseincode.com> >> --- >> include/linux/valign.h | 87 ++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> create mode 100644 include/linux/valign.h > You sent the same patch here, to two different trees (usb and > networking). That's not good, what happens if they both apply them? Good point. My mistake.
People in both subsystems needed to see the patch which is why I sent them.
What would have been a better approach? And how can I fix this?
Behan
-- Behan Webster behanw@converseincode.com
| |