Messages in this thread | | | Subject | Re: [PATCH 06/32] nohz/cpuset: Dont turn off the tick if rcu needs it | From | Steven Rostedt <> | Date | Tue, 30 Oct 2012 14:30:36 -0400 |
| |
On Mon, 2012-10-29 at 16:27 -0400, Steven Rostedt wrote: > plain text document attachment > (0006-nohz-cpuset-Don-t-turn-off-the-tick-if-rcu-needs-it.patch) > From: Frederic Weisbecker <fweisbec@gmail.com> > > If RCU is waiting for the current CPU to complete a grace > period, don't turn off the tick. Unlike dynctik-idle, we > are not necessarily going to enter into rcu extended quiescent > state, so we may need to keep the tick to note current CPU's > quiescent states. > > [added build fix from Zen Lin]
I don't see anything obviously troubling in this patch.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Alessio Igor Bogani <abogani@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Avi Kivity <avi@redhat.com> > Cc: Chris Metcalf <cmetcalf@tilera.com> > Cc: Christoph Lameter <cl@linux.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Geoff Levand <geoff@infradead.org> > Cc: Gilad Ben Yossef <gilad@benyossef.com> > Cc: Hakan Akkan <hakanakkan@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Kevin Hilman <khilman@ti.com> > Cc: Max Krasnyansky <maxk@qualcomm.com> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Stephen Hemminger <shemminger@vyatta.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Sven-Thorsten Dietrich <thebigcorporation@gmail.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| |