Messages in this thread | | | Date | Tue, 30 Oct 2012 09:45:20 -0700 | Subject | Re: [PATCH] pstore: fix NULL pointer dereference in console writes | From | Kees Cook <> |
| |
On Tue, Oct 30, 2012 at 7:40 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Passing a NULL id causes a NULL pointer deference in writers > such as erst_writer and efi_pstore_write because they expect > to update this id. Pass a dummy id instead. > > This avoids a cascade of oopses caused when the initial > pstore_console_write passes a null which in turn causes > writes to the console causing further oopses in subsequent > pstore_console_write calls. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Good catch; thanks!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook Chrome OS Security
| |