Messages in this thread | | | Date | Tue, 30 Oct 2012 14:35:15 +0200 | From | Felipe Balbi <> | Subject | Re: [PATCH 2/3] dma: move dw_dmac driver to an own directory |
| |
Hi,
On Tue, Oct 30, 2012 at 02:32:11PM +0200, Andy Shevchenko wrote: > The dw_dmac driver contains multiple files. To make a management of them more > convenient move it to an own directory. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: Felipe Balbi <balbi@ti.com> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/dma/Makefile | 3 +-- > drivers/dma/dw/Makefile | 2 ++ > drivers/dma/{ => dw}/dw_dmac.c | 2 +- > drivers/dma/{ => dw}/dw_dmac_pci.c | 0 > drivers/dma/{ => dw}/dw_dmac_regs.h | 0 > 5 files changed, 4 insertions(+), 3 deletions(-) > create mode 100644 drivers/dma/dw/Makefile > rename drivers/dma/{ => dw}/dw_dmac.c (99%) > rename drivers/dma/{ => dw}/dw_dmac_pci.c (100%) > rename drivers/dma/{ => dw}/dw_dmac_regs.h (100%) > > diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile > index 15eef5f..122a48a 100644 > --- a/drivers/dma/Makefile > +++ b/drivers/dma/Makefile > @@ -11,8 +11,7 @@ obj-$(CONFIG_INTEL_IOP_ADMA) += iop-adma.o > obj-$(CONFIG_FSL_DMA) += fsldma.o > obj-$(CONFIG_MPC512X_DMA) += mpc512x_dma.o > obj-$(CONFIG_MV_XOR) += mv_xor.o > -obj-$(CONFIG_DW_DMAC) += dw_dmac.o > -obj-$(CONFIG_DW_DMAC_PCI) += dw_dmac_pci.o > +obj-$(CONFIG_DW_DMAC) += dw/
this is wrong, I guess. If you want dw_dmac_pci.o to be statically built-in, but dw_dmac.o to be a dynamic module, according to this Makefile entry, dw_dmac_pci.o will be linked to vmlinux.
-- balbi [unhandled content-type:application/pgp-signature] | |