| Date | Mon, 29 Oct 2012 22:01:52 -0700 | From | Dmitry Torokhov <> | Subject | Re: [Pv-drivers] [PATCH 05/12] VMCI: event handling implementation. |
| |
On Mon, Oct 29, 2012 at 07:26:05PM -0700, Greg KH wrote: > On Mon, Oct 29, 2012 at 06:04:27PM -0700, George Zhang wrote: > > +static void event_signal_destroy(struct kref *kref) > > +{ > > + struct vmci_subscription *entry = > > + container_of(kref, struct vmci_subscription, kref); > > + > > + complete(&entry->done); > > +} > > Didn't you just leak memory here? What frees the structure up?
event_unregister_subscription() waits for that completion and frees the structure. We want event_unregister_subscription() to wait until all fired callbacks completed before unregister is complete.
Thanks, Dmitry
|