lkml.org 
[lkml]   [2012]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rcu: Remove rcu_switch()
On Wed, Oct 03, 2012 at 10:05:43PM +0200, Frederic Weisbecker wrote:
> On Wed, Oct 03, 2012 at 11:39:45AM -0700, Paul E. McKenney wrote:
> > On Wed, Oct 03, 2012 at 08:21:52PM +0200, Frederic Weisbecker wrote:
> > > It's only there to call rcu_user_hooks_switch(). Let's
> > > just call rcu_user_hooks_switch() directly, we don't need this
> > > function in the middle.
> >
> > Hello, Frederic!
> >
> > Doesn't this also require an empty definition of rcu_user_hooks_switch()
> > to handle the CONFIG_RCU_USER_QS=n case? Or is there already such
> > a definition that I am too blind to see?
>
> There is, look below:

Right you are! Queued.

Thanx, Paul

> > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > > Cc: Josh Triplett <josh@joshtriplett.org>
> > > Cc: Peter Zijlstra <peterz@infradead.org>
> > > ---
> > > include/linux/rcupdate.h | 2 ++
> > > include/linux/sched.h | 8 --------
> > > kernel/sched/core.c | 2 +-
> > > 3 files changed, 3 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> > > index 7c968e4..5d009de 100644
> > > --- a/include/linux/rcupdate.h
> > > +++ b/include/linux/rcupdate.h
> > > @@ -204,6 +204,8 @@ static inline void rcu_user_enter(void) { }
> > > static inline void rcu_user_exit(void) { }
> > > static inline void rcu_user_enter_after_irq(void) { }
> > > static inline void rcu_user_exit_after_irq(void) { }
> > > +static inline void rcu_user_hooks_switch(struct task_struct *prev,
> > > + struct task_struct *next) { }
>
> Here.
>
> > > #endif /* CONFIG_RCU_USER_QS */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



\
 
 \ /
  Last update: 2012-10-03 23:21    [W:0.037 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site