This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Tue Apr 30 10:12:40 2024 Envelope-to: j@jasper.es Delivery-date: Wed, 03 Oct 2012 18:22:36 +0200 Received: from localhost ([127.0.0.1] helo=squeeze.vs19.net) by squeeze.vs19.net with esmtp (Exim 4.72) (envelope-from ) id 1TJRiV-0006ZJ-MU for j@jasper.es; Wed, 03 Oct 2012 18:22:35 +0200 Received: from pop3.telfort.nl [213.205.33.252] by squeeze.vs19.net with POP3 (fetchmail-6.3.18) for (single-drop); Wed, 03 Oct 2012 18:22:35 +0200 (CEST) Received: from cmgw-nl-2 (10.39.115.162) by mda-nl-2.mail.tiscali.sys (8.5.142) id 4FC4EF900235F736 for jasper@telfort.nl; Wed, 3 Oct 2012 18:15:37 +0200 Received: from cpsmtpb-ews10.kpnxchange.com ([213.75.39.15]) by cmgw-nl-2 with id 6gFc1k0010Kd0Rx01gFdm0; Wed, 03 Oct 2012 18:15:37 +0200 X-CNFS-Analysis: v=2.0 cv=e6iEuNV/ c=1 sm=2 a=UK1r566ZdBxH71SXbqIOeA==:17 a=eDIeB8hCkPEA:10 a=4xmMjYyfM0YA:10 a=-dChlVsmAwQA:10 a=IkcTkHD0fZMA:10 a=iksOf1Zi8KMA:10 a=jdP34snFAAAA:8 a=VwQbUJbxAAAA:8 a=W0vUJOdyAAAA:8 a=ZFnRnkItj4Uyr5NcnycA:9 a=QEXdDO2ut3YA:10 a=x8gzFH9gYPw Received: from cpsps-ews11.kpnxchange.com ([10.94.84.178]) by cpsmtpb-ews10.kpnxchange.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 3 Oct 2012 18:15:37 +0200 Received: from vger.kernel.org ([209.132.180.67]) by cpsps-ews11.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Wed, 3 Oct 2012 18:15:37 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756474Ab2JCQPA (ORCPT ); Wed, 3 Oct 2012 12:15:00 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:56925 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756360Ab2JCQO6 (ORCPT ); Wed, 3 Oct 2012 12:14:58 -0400 Received: by eekb15 with SMTP id b15so4153577eek.19 for ; Wed, 03 Oct 2012 09:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=G4YU9 Received: by 10.14.218.134 with SMTP id k6mr3506655eep.14.1349280897301; Wed, 03 Oct 2012 09:14:57 -0700 (PDT) Received: from flexo.localnet (freebox.vlq16.iliad.fr. [213.36.7.13]) by mx.google.com with ESMTPS id n45sm10479940eeo.14.2012.10.03.09.14.55 (version=SSLv3 cipher=OTHER); Wed, 03 Oct 2012 09:14:56 -0700 (PDT) From: Florian Fainelli To: Manuel Lauss Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, Ralf Baechle , Manuel Lauss , Thomas Meyer , "David S. Miller" , linux-mips@linux-mips.org, linux-kernel@vger.ke Subject: Re: [PATCH 24/25] MIPS: Alchemy: use the OHCI platform driver Date: Wed, 03 Oct 2012 18:13:52 +0200 Message-Id: <1552014.pCMX6Sqj22@flexo> Organization: OpenWrt User-Agent: KMail/4.8.5 (Linux/3.2.0-24-generic; KDE/4.8.5; x86_64; ; ) In-Reply-To: References: <1349276601-8371-1-git-send-email-florian@openwrt.org> <1349276601-8371-26-git-send-email-florian@openwrt.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-OriginalArrivalTime: 03 Oct 2012 16:15:37.0132 (UTC) FILETIME=[52D7FEC0:01CDA182] X-RcptDomain: telfort.nl On Wednesday 03 October 2012 18:07:28 Manuel Lauss wrote: > On Wed, Oct 3, 2012 at 5:03 PM, Florian Fainelli wrote: > > This also greatly simplifies the power_{on,off} callbacks and make them > > work on platform device id instead of checking the OHCI controller base > > address like what was done in ohci-au1xxx.c. > > > > Signed-off-by: Florian Fainelli > > --- > > arch/mips/alchemy/common/platform.c | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common/platform.c > > index 57335a2..cd12458 100644 > > --- a/arch/mips/alchemy/common/platform.c > > +++ b/arch/mips/alchemy/common/platform.c > > @@ -18,6 +18,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -142,6 +143,34 @@ static struct usb_ehci_pdata alchemy_ehci_pdata = { > > .power_suspend = alchemy_ehci_power_off, > > }; > > > > +/* Power on callback for the ohci platform driver */ > > +static int alchemy_ohci_power_on(struct platform_device *pdev) > > +{ > > + int unit; > > + > > + unit = (pdev->id == 1) ? > > + ALCHEMY_USB_OHCI1 : ALCHEMY_USB_OHCI0; > > + > > + return alchemy_usb_control(unit, 1); > > +} > > + > > +/* Power off/suspend callback for the ohci platform driver */ > > +static void alchemy_ohci_power_off(struct platform_device *pdev) > > +{ > > + int unit; > > + > > + unit = (pdev->id == 1) ? > > + ALCHEMY_USB_OHCI1 : ALCHEMY_USB_OHCI0; > > + > > + alchemy_usb_control(unit, 0); > > +} > > + > > +static struct usb_ohci_pdata alchemy_ohci_pdata = { > > + .power_on = alchemy_ohci_power_on, > > + .power_off = alchemy_ohci_power_off, > > + .power_suspend = alchemy_ohci_power_off, > > +}; > > + > > static unsigned long alchemy_ohci_data[][2] __initdata = { > > [ALCHEMY_CPU_AU1000] = { AU1000_USB_OHCI_PHYS_ADDR, AU1000_USB_HOST_INT }, > > [ALCHEMY_CPU_AU1500] = { AU1000_USB_OHCI_PHYS_ADDR, AU1500_USB_HOST_INT }, > > @@ -192,6 +221,7 @@ static void __init alchemy_setup_usb(int ctype) > > pdev->name = "au1xxx-ohci"; > > Should be "ohci-platform" (2x). With this change USB works on all my > Alchemy boards. Yes, Hauke Merthens just pointed this issue at me. > I'd also suggest to move drivers/usb/host/alchemy-common.c to > arch/mips/alchemy/common/usb.c. > (same for octeon2-common.c) Ok, sounds good. -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/