Messages in this thread | | | Date | Wed, 3 Oct 2012 15:46:54 +0200 (CEST) | From | Lukáš Czerner <> | Subject | Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region |
| |
On Wed, 5 Sep 2012, Douglas Gilbert wrote:
> Date: Wed, 05 Sep 2012 15:41:13 -0400 > From: Douglas Gilbert <dgilbert@interlog.com> > To: Martin K. Petersen <martin.petersen@oracle.com> > Cc: Lukas Czerner <lczerner@redhat.com>, linux-scsi@vger.kernel.org, > JBottomley@parallels.com, tytso@mit.edu, pbonzini@redhat.com, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region > > On 12-08-17 12:11 PM, Martin K. Petersen wrote: > > > > > > > "Lukas" == Lukas Czerner <lczerner@redhat.com> writes: > > > > Lukas> Currently it is possible to unmap one more block than user > > Lukas> requested to due to the off-by-one error in unmap_region(). This > > Lukas> is probably due to the fact that the end variable despite its > > Lukas> name actually points to the last block to unmap + 1. However in > > Lukas> the condition it is handled as the last block of the region to > > Lukas> unmap. > > > > Acked-by: Martin K. Petersen <martin.petersen@oracle.com> > > Acked-by: Douglas Gilbert <dgilbert@interlog.com>
James, could you please pick this one ?
Thanks! -Lukas
| |