lkml.org 
[lkml]   [2012]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv4] perf x86_64: Fix rsp register for system call fast path
On Wed, Oct 03, 2012 at 03:22:17PM +0200, Peter Zijlstra wrote:
> On Wed, 2012-10-03 at 15:13 +0200, Jiri Olsa wrote:
> > @@ -1190,8 +1191,8 @@ static inline void perf_sample_data_init(struct
> > perf_sample_data *data,
> > data->raw = NULL;
> > data->br_stack = NULL;
> > data->period = period;
> > - data->regs_user.abi = PERF_SAMPLE_REGS_ABI_NONE;
> > - data->regs_user.regs = NULL;
> > + /* Sets abi to PERF_SAMPLE_REGS_ABI_NONE. */
> > + memset(&data->regs_user, 0, sizeof(data->regs_user));
> > data->stack_user_size = 0;
> > }
>
> Hmm, this will slow down all events, regardless of whether they use any
> of that stuff or not. Since the one user actually does something like:
>
> data->regs_user = *pt_regs;
>
> except it does a memcpy() for some obscure reason, it really doesn't
> matter what is in there when uninitialized, right?

right, the init can stay as it was

jirka


\
 
 \ /
  Last update: 2012-10-03 16:01    [W:0.034 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site