Messages in this thread | | | Date | Wed, 3 Oct 2012 05:11:32 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation |
| |
> > - eventsel & ARCH_PERFMON_EVENTSEL_INT); > > + eventsel & ARCH_PERFMON_EVENTSEL_INT, > > + !!(eventsel & HSW_INTX), > > + !!(eventsel & HSW_INTX_CHECKPOINTED)); > > } > > > > Those !! are !necessary, since the formal argument is a bool.
bool is 1 or 0, x & y with y > 1 is not 1 or 0. iirc assigning > 1 to bool is undefined
So I think they are necessary.
Or did I misundersand you?
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |