Messages in this thread | | | Date | Wed, 3 Oct 2012 07:47:21 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/6] target/file: Re-enable optional fd_buffered_io=1 operation |
| |
On Tue, Oct 02, 2012 at 01:16:44PM -0700, Nicholas A. Bellinger wrote: > * Optionally allow fd_buffered_io=1 to be enabled for people > * who want use the fs buffer cache as an WriteCache mechanism. > * > * This means that in event of a hard failure, there is a risk > * of silent data-loss if the SCSI client has *not* performed a > * forced unit access (FUA) write, or issued SYNCHRONIZE_CACHE > * to write-out the entire device cache. > */
Oh, I get Vlads flame. This doesn't simply disable O_DSYNC now but also sets WCE=1. In this case I don't really get the point of the patch, why can't we simply set it from configfs?
| |