Messages in this thread | | | From | "Henrik Rydberg" <> | Date | Mon, 29 Oct 2012 20:25:58 +0100 | Subject | Re: [PATCH v2 03/11] HID: hid-input: add usage_index argument in input_mapping and event. |
| |
Hi Benjamin,
> Currently, there is no way to know the index of the current field > in the .input_mapping and .event callbacks when this field is inside > an array of HID fields. > This patch forwards this index to the input_mapping and event > callbacks.
I agree with the idea, but the function argument list is becoming ridiculously long... Could we remove the usage pointer argument, at least?
int (*event)(struct hid_device *hdev, struct hid_field *field, unsigned int usage_index, __s32 value);
> @@ -1071,19 +1072,24 @@ static void hid_input_field(struct hid_device *hid, struct hid_field *field, > for (n = 0; n < count; n++) { > > if (HID_MAIN_ITEM_VARIABLE & field->flags) { > - hid_process_event(hid, field, &field->usage[n], value[n], interrupt); > + hid_process_event(hid, field, &field->usage[n], n, > + value[n], interrupt); > continue; > } > > if (field->value[n] >= min && field->value[n] <= max > && field->usage[field->value[n] - min].hid > && search(value, field->value[n], count)) > - hid_process_event(hid, field, &field->usage[field->value[n] - min], 0, interrupt); > + hid_process_event(hid, field, > + &field->usage[field->value[n] - min], n, > + 0, interrupt);
Wrong index?
> > if (value[n] >= min && value[n] <= max > && field->usage[value[n] - min].hid > && search(field->value, value[n], count)) > - hid_process_event(hid, field, &field->usage[value[n] - min], 1, interrupt); > + hid_process_event(hid, field, > + &field->usage[value[n] - min], n, > + 1, interrupt);
Wrong index?
> } > > memcpy(field->value, value, count * sizeof(__s32));
Thanks, Henrik
| |