Messages in this thread | | | Date | Wed, 31 Oct 2012 00:05:53 +0800 | From | Feng Tang <> | Subject | Re: [PATCH v5 5/8] perf ui/browser: Integrate script browser into main hists browser |
| |
On Mon, Oct 29, 2012 at 12:54:23PM -0200, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 30, 2012 at 11:56:06AM +0800, Feng Tang escreveu: > > Integrate the script browser into "perf report" framework, users can > > use function key 'r' or the drop down menu to list all perf scripts > > and select one of them, just like they did for the annotation. > > > > Signed-off-by: Feng Tang <feng.tang@intel.com> > > I noticed this comment on another patch: > > -------------------------- > This initial version only enables it for 'perf report', by checking > the "timer" parameter of perf_evsel__hists_browser() equals NULL. > -------------------------- > > Yeah, one can say that if a timer is provided, we can say its 'top' and > not 'report', at least as things stand now. > > So please add a 'is_top(void *timer)' so that we know the intent more > clearly and use it to avoid showing the 'r' key when in 'top' mode, ok?
Will do and thanks for the catch. I once thought about hiding script option for 'top' mode, but forgot to follow it on.
Thanks, Feng
| |